🐛 fix(ci): Resolve build and SDK download issues#25
Open
kirill-jjj wants to merge 2 commits intoBlindMaster24:masterfrom
Open
🐛 fix(ci): Resolve build and SDK download issues#25kirill-jjj wants to merge 2 commits intoBlindMaster24:masterfrom
kirill-jjj wants to merge 2 commits intoBlindMaster24:masterfrom
Conversation
Reverts to the previous mechanism of downloading the TeamTalk SDK automatically when the `pytalk` package is imported. This logic was removed in a previous refactor, but the explicit download step added to the CI was not implemented correctly, causing CI failures. Restoring this logic ensures the SDK is present before the type-checking and testing steps are run in the CI workflow.
Apply formatting changes made by the `end-of-file-fixer` pre-commit hook to `tests/unit/test_bot.py`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves several CI build failures:
pytalk/__init__.py, ensuring the SDK is available for type-checking and tests.